Topic: 2.4.20 no OPENSSL_Applink error

[Steady]

Hi,

I haven't used abs in some time but trying to use it in the 2.4.20 release I get

OPENSSL_Uplink(000007FEDF828000,08): no OPENSSL_Applink

Does anyone else experience this error? I do have httpd running without any issues using mod_ssl.

Thanks
Ed

[Steffen]

yep same error here. Never tested with the latest OpenSSL versions. Known error with OpenSSL, see https://www.openssl.org/docs/faq.html#PROG2



Please try:

Download removed, new abs.exe with Applink is now in 2.4.23+

Thanks for letting us know !

[Steady]

Hi Steffen,

Confirming it works as expected, thanks for that quick fix!

Ed

[glsmith]

Off forum I was told that AH builds suffer the same fate but I cannot duplicate.

[glsmith]

I was using a VC9 build when I tested it first. I am surprised it works without Applink yet VC14 builds do not.

I also found that if built with LibreSSL it is also not needed even in VC14.

[Jan-E]

openssl/applink.c is only required for VC14. The PHP guys ran into the issue when compiling PHP 7.0.0 Beta 1 switched to using VC14.

Their original patch is here:
http://git.php.net/?p=php-src.git;a=commitdiff;h=3d7343f609b81ebac95d94480a2615df530806e7

For abs.exe you could use something like this inside the #if defined(HAVE_OPENSSL) block of support/ab.c:

[James Blond]

Jan open a bug at https://bz.apache.org/bugzilla/ with a unified diff file attached.

[Jan-E]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59630

I had the usual troubles with Windows line-endings. My SlikSVN added \r's. I switched to cygwin's svn.

If this one is merged, I have got another one for ApacheMonitor. See http://mail-archives.apache.org/mod_mbox/httpd-dev/201505.mbox/%3CD52AAC5911334A719DB2FAAF2D1C1C7C@father%3E

[glsmith]

Can I see the patch?

[Jan-E]

YM the patch for ApacheMonitor? Sure. I tested this even yesterday, while compiling httpd with mod_h2 v1.5.6 in all the 6 variants.

[Steffen]

Jan_E, your proposed patch with abs is:

+#if defined(_MSC_VER) && _MSC_VER >= 1900
+#include <openssl/applink.c>
+#endif
+

So applink is included also for ab.exe and when you do not use OpenSSL (like LibreSSL)

So better to add condition:

#if defined(HAVE_OPENSSL)
#include <openssl/applink.c>

[Jan-E]

@Steffen: the added lines are already inside a block with

#if defined(HAVE_OPENSSL)

That block starts at line 159 and ends just after the addition.

[Steffen]

I see now.

[glsmith]

RE: Your apachemonitor patch, it needs to exclude from VC12 (_MSC_VER < 1800) as well

Also, I would like to retain VC6 compat as long as possible, IIRC it has troubles when the # is not the first character of a line but I deal with that if needed next time I build VC6. Anyhow, Apachemonitor is "non-unix, single platform" code and qualifies as CTR in 2.4.

This has been on my TODO list for awhile now, thanks for the push.
Commit to trunk: r1745516
Commit to 2.4: r1745517

I tried every possible way to get the setargv.obj included an no go until I created a static lib from it, then it gladly linked it all. If there's a way to figure out what the location of anyone's VC we could do this during a prebuild step but so far I haven't found a good way to find VC's LIB folder. I have an idea, just haven't tried it yet.

[Jan-E]

@Gregg: could you commit the on-topic patch as well? The one in https://bz.apache.org/bugzilla/show_bug.cgi?id=59630

W.r.t setargv.obj: I just did a dir *.obj in VC14's lib dir. 24 files, some with intriguing names like notelemetry.obj.
There must be a simple way to link those files. A creative use of %lib% or something like that.

[glsmith]

RE: Apachemonitor
I think I figured it out. After all I have a pre-build script I use to "do stuff" and it figures out what version of VC I am on and I can use that as a starting point. The Environment is your friend and looking at it again it's even friendlier.

RE: Applink
What about httpd.exe or mod_ssl, whichever? Then again it seems not to need it.

I would actually prefer to add it to the build than make that change to any .c file. I tried this method recently and it worked fine. This can also be targeted to abs.exe only, which is all that needs it.

[glsmith]

I think the problem was I should not have been thinking that day I came up with adding it to the build, then all VC version would get it. @ myself.

Commited to trunk: r1745767
Proposed for 2.4: r1745768

[glsmith]

Committed to 2.4 r1748449

[Jan-E]

But the discussion continues, I see.