Keep Server Online
If you find the Apache Lounge, the downloads and overall help useful, please express your satisfaction with a donation.
or
A donation makes a contribution towards the costs, the time and effort that's going in this site and building.
Thank You! Steffen
Your donations will help to keep this site alive and well, and continuing building binaries. Apache Lounge is not sponsored.
| |
|
 Topic: pecl-memcache for php8 |
|
| Author |
|
nono303
Joined: 20 Dec 2016
Posts: 205
Location: Lille, FR, EU
|
 Posted: Sat 14 Nov '20 9:31 Post subject: pecl-memcache for php8 |
 |
|
Hi,
I've got the same issue for compiling pecl-memcache for php8 than the once fixed for pecl-search_engine-solr in PR22
@Jan-E, could you confirm that missing (or suppressed?) win32/php_stdint.h file in php8-src must be replaced by inttypes.h and not main/php_stdint.h?
Thanks! |
|
| Back to top |
|
Jan-E
Joined: 09 Mar 2012
Posts: 1265
Location: Amsterdam, NL, EU
|
| Posted: Sun 15 Nov '20 15:08 Post subject: |
|
|
I had no problem when I replaced all the instances of win32/php_stdint.h in the memcache source by main/php_stdint.h:
| Code: | diff --git a/src/memcache_binary_protocol.c b/src/memcache_binary_protocol.c
index 707b351..1dc8fc6 100644
--- a/src/memcache_binary_protocol.c
+++ b/src/memcache_binary_protocol.c
@@ -26,7 +26,7 @@
#define MMC_DEBUG 0
#ifdef PHP_WIN32
-#include <win32/php_stdint.h>
+#include <main/php_stdint.h>
#include <winsock2.h>
#else
#include <stdint.h>
diff --git a/src/memcache_pool.h b/src/memcache_pool.h
index cb3d086..3a2ddc2 100644
--- a/src/memcache_pool.h
+++ b/src/memcache_pool.h
@@ -35,7 +35,7 @@
#endif
#ifdef PHP_WIN32
-#include <win32/php_stdint.h>
+#include <main/php_stdint.h>
#else
#include <stdint.h>
#endif
|
See https://www.apachelounge.com/viewtopic.php?t=6617 now |
|
| Back to top |
|
Jan-E
Joined: 09 Mar 2012
Posts: 1265
Location: Amsterdam, NL, EU
|
| Posted: Sun 15 Nov '20 15:10 Post subject: |
|
|
| That was a patch for the NON_BLOCKING_IO_php8 branch of memcache. |
|
| Back to top |
|
nono303
Joined: 20 Dec 2016
Posts: 205
Location: Lille, FR, EU
|
| Posted: Sun 15 Nov '20 17:53 Post subject: |
|
|
Thanks @Jan-E!
Yes, it's for NON_BLOCKING_IO_php8 branch.
Actually Have this working patch with pr77 & pr78 & +#include <inttypes.h> for commit e090f05.
Will have a look if I see difference with main/php_stdint.h |
|
| Back to top |
|
Jan-E
Joined: 09 Mar 2012
Posts: 1265
Location: Amsterdam, NL, EU
|
| Posted: Wed 18 Nov '20 14:04 Post subject: |
|
|
BTW. a generic solution could use something like this
| Code: | #if defined(_MSC_VER) && _MSC_VER <= 1916
#include <win32/php_stdint.h>
#else
#include <main/php_stdint.h>
#endif
|
It checks if a MSVC compiler is used and if the VC compiler is VC15 or less. |
|
| Back to top |
|
nono303
Joined: 20 Dec 2016
Posts: 205
Location: Lille, FR, EU
|
| Posted: Fri 23 Jul '21 8:38 Post subject: |
|
|
new released version 8.1-dev ccf702b (2021-06-15)
added vs17 (Visual Studio 2022 - 14.30) for testing |
|
| Back to top |
|
|
|
|
|
|
